Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add couple python dependencies #119573

Merged
merged 3 commits into from Apr 22, 2021
Merged

Add couple python dependencies #119573

merged 3 commits into from Apr 22, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

Add glances optional dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkPhase can be replaced with pytestCheckHook or doCheck = false; should be set if there are no tests.

pkgs/development/python-modules/py3nvml/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/py3nvml/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pySMART_smartx/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sparklines/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 15, 2021

Result of nixpkgs-review pr 119573 at 7f7b3c7a run on aarch64-linux 1

8 packages built successfully:
  • python38Packages.py3nvml
  • python38Packages.pySMART_smartx
  • python38Packages.pymdstat
  • python38Packages.sparklines
  • python39Packages.py3nvml
  • python39Packages.pySMART_smartx
  • python39Packages.pymdstat
  • python39Packages.sparklines
7 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/pymdstat/default.nix:15:3:

       |
    15 |   meta = with lib; {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/sparklines/default.nix:27:3:

       |
    27 |   meta = with lib; {
       |   ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pySMART_smartx/default.nix:16:0:

       |
    16 |     description = "It's a fork of pySMART with lots of bug fix and enhances";
       | ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/py3nvml/default.nix:18:3:

       |
    18 |   meta = with lib; {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/pySMART_smartx/default.nix:15:3:

       |
    15 |   meta = with lib; {
       |   ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/py3nvml/default.nix:19:0:

       |
    19 |     description = "Python 3 compatible bindings to the NVIDIA Management Library";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pymdstat/default.nix:16:0:

       |
    16 |     description = "A pythonic library to parse Linux /proc/mdstat file";
       | ^
    

Result of nixpkgs-review pr 119573 at 7f7b3c7a run on x86_64-linux 1

8 packages built successfully:
  • python38Packages.py3nvml
  • python38Packages.pySMART_smartx
  • python38Packages.pymdstat
  • python38Packages.sparklines
  • python39Packages.py3nvml
  • python39Packages.pySMART_smartx
  • python39Packages.pymdstat
  • python39Packages.sparklines
7 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/py3nvml/default.nix:18:3:

       |
    18 |   meta = with lib; {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/pySMART_smartx/default.nix:15:3:

       |
    15 |   meta = with lib; {
       |   ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/py3nvml/default.nix:19:0:

       |
    19 |     description = "Python 3 compatible bindings to the NVIDIA Management Library";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pymdstat/default.nix:16:0:

       |
    16 |     description = "A pythonic library to parse Linux /proc/mdstat file";
       | ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/sparklines/default.nix:27:3:

       |
    27 |   meta = with lib; {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/pymdstat/default.nix:15:3:

       |
    15 |   meta = with lib; {
       |   ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pySMART_smartx/default.nix:16:0:

       |
    16 |     description = "It's a fork of pySMART with lots of bug fix and enhances";
       | ^
    

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the maintainer applies to all packages the tests only to those which are not running the tests now.

pkgs/development/python-modules/py3nvml/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/py3nvml/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pySMART_smartx/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sparklines/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sparklines/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 50c970f into NixOS:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants