Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash: 4.3.0 -> 4.4.0 #119579

Merged
merged 2 commits into from Apr 15, 2021
Merged

zcash: 4.3.0 -> 4.4.0 #119579

merged 2 commits into from Apr 15, 2021

Conversation

centromere
Copy link
Member

Motivation for this change

Bump to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht and tkerber April 15, 2021 22:11
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 15, 2021 •
edited

Result of nixpkgs-review pr 119579 at 2898828 run on aarch64-linux 1

1 package built successfully:
  • zcash
1 suggestion:
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/applications/blockchains/zcash/default.nix:2:3:

      |
2 | , fetchpatch, cargo, pkg-config, curl, coreutils, boost174, db62, hexdump
  |   ^

Result of nixpkgs-review pr 119579 at 49bc516 run on x86_64-linux 1

1 package built successfully:
  • zcash

@SuperSandro2000 SuperSandro2000 merged commit 22fb445 into NixOS:master Apr 15, 2021
@centromere centromere deleted the zcash-4.4.0 branch April 15, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

@rht rht Awaiting requested review from rht

@tkerber tkerber Awaiting requested review from tkerber

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@centromere @r-rmcgibbo @SuperSandro2000