Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-agent: fix systemd unit #119632

Merged
merged 1 commit into from Apr 16, 2021

Conversation

philandstuff
Copy link
Contributor

@philandstuff philandstuff commented Apr 16, 2021

Motivation for this change

I was getting problems with the unit failing to start due to NAMESPACE
or CAPABILITIES permissions.

Upstream now provides a systemd unit file in the repo, we should use that
one, and that one works for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I was getting problems with the unit failing to start due to NAMESPACE
or CAPABILITIES permissions.

Upstream now provides a systemd unit file in the repo, we should use that
one, and that one works for me.
@philandstuff philandstuff force-pushed the yubikey-agent/fix-systemd-unit branch from d9583ee to dfb0999 Compare April 16, 2021 19:46
@prusnak prusnak merged commit a2f6801 into NixOS:master Apr 16, 2021
@philandstuff philandstuff deleted the yubikey-agent/fix-systemd-unit branch April 19, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants