New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oh-my-git: init at 0.6.4 #119642
oh-my-git: init at 0.6.4 #119642
Conversation
Result of 2 packages built successfully:
|
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the packages! ✨
You should add git as runtime dependency. Someone who plays this game to learn git might not have it installed already.
tested with:
[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ nix-shell -p --pure
[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ git
The program 'git' is not in your PATH. It is provided by several packages.
You can make it available in an ephemeral shell by typing one of the following:
nix-shell -p git
nix-shell -p git-doc
nix-shell -p gitMinimal
nix-shell -p gitSVN
[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ results/oh-my-git/bin/oh-my-git
Change looks otherwise good.
Builds and works. Even finds my previous savegame :)
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Builds, works
@SuperSandro2000 do you want to add a second review and merge? |
Motivation for this change
Add the package for @davidak's package request. Closes #112341. I played about half of the levels and there seem to be no problems running the game.
The godot export commands expects a copy of the godot export templates at
$HOME/.local/share/godot/templates/3.2.3.stable/...
. First i downloaded the zip archive from https://godotengine.org/download and copied the templates to the expected location. But the version of these export templates and the godot compiler need to be in sync.Therefore i added
godot-export-templates
based on theheadless
/server
package. Now the version of godot and the export templates are automatically in sync.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)