Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-my-git: init at 0.6.4 #119642

Merged
merged 2 commits into from Apr 19, 2021
Merged

oh-my-git: init at 0.6.4 #119642

merged 2 commits into from Apr 19, 2021

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Apr 16, 2021

Motivation for this change

Add the package for @davidak's package request. Closes #112341. I played about half of the levels and there seem to be no problems running the game.

The godot export commands expects a copy of the godot export templates at $HOME/.local/share/godot/templates/3.2.3.stable/.... First i downloaded the zip archive from https://godotengine.org/download and copied the templates to the expected location. But the version of these export templates and the godot compiler need to be in sync.

Therefore i added godot-export-templates based on the headless/server package. Now the version of godot and the export templates are automatically in sync.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/xx9zihn59643p47b2qgyl05qxk4b8qrq-oh-my-git-0.6.4	 396.7M
/nix/store/hk6l3krh3aps7a6pkxbf6p1kp1zyvbc4-godot-export-templates-3.2.3	 391.6M

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119642 at cc6cd3c8 run on x86_64-linux 1

2 packages built successfully:
  • godot-export-templates
  • oh-my-git

@davidak
Copy link
Member

davidak commented Apr 18, 2021

Result of nixpkgs-review pr 119642 run on x86_64-linux 1

2 packages built:
  • godot-export-templates
  • oh-my-git

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the packages! ✨

You should add git as runtime dependency. Someone who plays this game to learn git might not have it installed already.

tested with:

[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ nix-shell -p --pure

[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ git
The program 'git' is not in your PATH. It is provided by several packages.
You can make it available in an ephemeral shell by typing one of the following:
  nix-shell -p git
  nix-shell -p git-doc
  nix-shell -p gitMinimal
  nix-shell -p gitSVN

[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ results/oh-my-git/bin/oh-my-git

Screenshot from 2021-04-18 05-17-58

Change looks otherwise good.

Builds and works. Even finds my previous savegame :)

pkgs/games/oh-my-git/default.nix Show resolved Hide resolved
@davidak
Copy link
Member

davidak commented Apr 18, 2021

Result of nixpkgs-review pr 119642 run on x86_64-linux 1

2 packages built:
  • godot-export-templates
  • oh-my-git

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Builds, works

@davidak
Copy link
Member

davidak commented Apr 18, 2021

@SuperSandro2000 do you want to add a second review and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please package oh-my-git
4 participants