Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profanity: Enable clipboard support #119654

Merged
merged 1 commit into from Apr 16, 2021
Merged

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Apr 16, 2021

Motivation for this change

Clipboard support was actually introduced in version 0.8.0, and this
change flew completely over my head. Now the /paste command should
actually work by default and as expected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Clipboard support was actually introduced in version `0.8.0`, and this
change flew completely over my head. Now the /paste command should
actually work by default and as expected.
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 16, 2021

Result of nixpkgs-review pr 119654 at fbffc54a run on x86_64-linux 1

1 package built successfully:
  • profanity
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/networking/instant-messengers/profanity/default.nix:34:5:

       |
    34 |     ./patches/packages-osx.patch
       |     ^
    

Result of nixpkgs-review pr 119654 at fbffc54a run on aarch64-linux 1

1 package built successfully:
  • profanity

@SuperSandro2000 SuperSandro2000 merged commit e6fc1de into NixOS:master Apr 16, 2021
@devhell devhell deleted the mod-profanity branch April 19, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants