Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd: fix qemu #119656

Closed
wants to merge 1 commit into from
Closed

lxd: fix qemu #119656

wants to merge 1 commit into from

Conversation

mkg20001
Copy link
Member

Motivation for this change

This fixes qemu.
Currently starting fails with lxd not being able to find the qemu-x86_64 binary
This PR simply replaces all /usr paths and adds the required tools to $PATH.

I'm currently using this in production and it seems to work well so far.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119656 at 441f87f run on x86_64-linux 1

1 package built successfully:
  • lxd
1 suggestion:
  • error: no-flags-spaces

    buildFlags cannot contain spaces, please use buildFlagsArray in Bash.

    Near pkgs/tools/admin/lxd/default.nix:50:3:

       |
    50 |   buildFlags = [ "-tags libsqlite3" ];
       |   ^
    

@stale
Copy link

stale bot commented Oct 22, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 22, 2021
@@ -30,6 +31,12 @@ buildGoPackage rec {
postPatch = ''
substituteInPlace shared/usbid/load.go \
--replace "/usr/share/misc/usb.ids" "${hwdata}/share/hwdata/usb.ids"
# Nuke from orbit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hilarious! Sure it helps?

# Substitute paths

@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Apr 23, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022
@adamcstephens
Copy link
Contributor

This was completed in #246221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants