Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bumping from v0.10.0 released in May 2019, to v0.18.0 released in March 2021. There are many improvements listed in the changelog. In terms of the derivation, there's a new dependency on Hunspell, and we switch from qmake to cmake as qmake doesn't find the hunspell library correctly. (It tries to link against
-lhunspell
, whereas cmake finds the correct-lhunspell-1.7
.)Since there's a PR open to bump LXQT, it seems like a good time to bump FeatherPad too.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)