Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featherpad: 0.10.0 -> 0.18.0 #119675

Merged
merged 2 commits into from Apr 20, 2021
Merged

Conversation

khumba
Copy link
Contributor

@khumba khumba commented Apr 17, 2021

Motivation for this change

Bumping from v0.10.0 released in May 2019, to v0.18.0 released in March 2021. There are many improvements listed in the changelog. In terms of the derivation, there's a new dependency on Hunspell, and we switch from qmake to cmake as qmake doesn't find the hunspell library correctly. (It tries to link against -lhunspell, whereas cmake finds the correct -lhunspell-1.7.)

Since there's a PR open to bump LXQT, it seems like a good time to bump FeatherPad too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • +2,726,520 bytes.
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 17, 2021

Result of nixpkgs-review pr 119675 at d791e96c run on x86_64-linux 1

1 package built successfully:
  • featherpad
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/editors/featherpad/default.nix:22:5:

       |
    22 |     license = licenses.gpl3;
       |     ^
    

Result of nixpkgs-review pr 119675 at d791e96c run on aarch64-linux 1

1 package built successfully:
  • featherpad

@SuperSandro2000 SuperSandro2000 merged commit 41714bb into NixOS:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants