Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.reflex-dom: Remove obsolete override do fix build #119692

Merged
merged 1 commit into from Apr 17, 2021
Merged

haskellPackages.reflex-dom: Remove obsolete override do fix build #119692

merged 1 commit into from Apr 17, 2021

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Apr 17, 2021 •
edited

Motivation for this change

This build failure somehow slipped through the cracks while merging the Haskell updates yesterday.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member Author

I am doing this intentionally against master because I want this fixed asap.

@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.reflex-dom

@maralorn
Copy link
Member Author

Result of nixpkgs-review pr 119692 1

@maralorn maralorn merged commit e1e163e into NixOS:master Apr 17, 2021
@maralorn maralorn deleted the fix-reflex branch April 17, 2021 09:15
@maralorn maralorn restored the fix-reflex branch April 17, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maralorn