Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subversion_1_10: 1.10.6 -> 1.10.7 #119695

Merged
merged 1 commit into from Apr 17, 2021
Merged

subversion_1_10: 1.10.6 -> 1.10.7 #119695

merged 1 commit into from Apr 17, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2020-17525.

Release announcement:
https://lists.apache.org/thread.html/r86eb93bd4e12c126203f61e9bd42f9a3905117842b481d20e15fd61f%40%3Cannounce.subversion.apache.org%3E

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • subversion_1_10

@ofborg ofborg bot requested review from lovek323 and edolstra April 17, 2021 10:07
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119695 at b660a15 run on x86_64-linux 1

1 package built successfully:
  • subversion_1_10
20 suggestions:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_diff-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_base-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_client-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_diff-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_util-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_x-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_ra-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_ra_local-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_client-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_delta-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_base-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_util-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_fs-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_delta-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_fs-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_fs_x-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/apxpi7w14qkvbkpiy89lryarxv9svngy-openssl-1.1.1k-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_ra-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/nix/store/p9ly9bawmldzmsryzd048xx2cbj5h757-expat-2.2.10-dev/lib' doesn't match anything in file '/nix/store/cghvsabx6ihxnibcr8nfwz0rv8brk8zc-subversion-1.10.7/lib/libsvn_ra_local-1.la'
    Near pkgs/applications/version-management/subversion/default.nix:99:0:

       |
99 |       description = "A version control system intended to be a compelling replacement for CVS in the open source community";
   | ^

@SuperSandro2000 SuperSandro2000 merged commit 0bb7055 into NixOS:master Apr 17, 2021
@LeSuisse LeSuisse deleted the subversion-1.10.7 branch April 17, 2021 14:33
@LeSuisse LeSuisse added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 17, 2021
@dotlambda
Copy link
Member

dotlambda commented Apr 25, 2021 •
edited

@LeSuisse Can we do the same for version 1.12? See #120419. Nvm, already done in #120562.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeSuisse @r-rmcgibbo @dotlambda @SuperSandro2000