Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnix-hashes: fix tests, add me as maintainer #119749

Merged
merged 2 commits into from Apr 18, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 17, 2021

Result of nixpkgs-review pr 119749 at 5de0ca5 run on x86_64-linux 1

1 package built successfully:
  • rnix-hashes
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/tools/nix/rnix-hashes/default.nix:15:5:

       |
    15 |     (fetchpatch {
       |     ^
    

Result of nixpkgs-review pr 119749 at 2174552 run on aarch64-linux 1

1 package built successfully:
  • rnix-hashes

@SuperSandro2000 SuperSandro2000 merged commit b2f2d04 into NixOS:master Apr 18, 2021
@SuperSandro2000 SuperSandro2000 deleted the rnix-hashes branch April 18, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants