Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsMacPort: 8.0 -> 8.2 #119767

Merged
merged 1 commit into from May 9, 2021
Merged

emacsMacPort: 8.0 -> 8.2 #119767

merged 1 commit into from May 9, 2021

Conversation

yuanw
Copy link
Contributor

@yuanw yuanw commented Apr 18, 2021

Motivation for this change

update emacsMacPort to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yuanw yuanw requested a review from adisbladis as a code owner April 18, 2021 02:47
@ofborg ofborg bot requested review from jwiegley and matthewbauer April 18, 2021 02:57
@SuperSandro2000 SuperSandro2000 changed the title bump emacsMacPort version to 8.2 emacsMacPort: 8.0 -> 8.2 Apr 18, 2021
@SuperSandro2000
Copy link
Member

Please squash when merging or update the commit message.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

emacsMacport: Ask if output path libexec (10.3M) could be split with outputs = [ ... "lib" ];
emacsMacport: Ask if output path share/info (4.7M) could be split with outputs = [ ... "info" ];

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 119767 run on x86_64-darwin 1

1 package built:
  • emacsMacport

@veprbl veprbl merged commit 0c04615 into NixOS:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants