Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/packagekit: fix test machine evaluation #119812

Merged
merged 1 commit into from Apr 18, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Apr 18, 2021

aa22be1 dropped the backend setting
which was used in the test, breaking evaluation of the test in the
process. Kind of defeats the purpose of a test if it isn't executed
before merging a change to a module…

cc @peterhoeg

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aa22be1 dropped the backend setting
which was used in the test, breaking evaluation of the test in the
process. Kind of defeats the purpose of a test if it isn't executed
before merging a change to a module…
@sternenseemann
Copy link
Member Author

@ofborg test packagekit

@SuperSandro2000 SuperSandro2000 merged commit f3a1bb4 into NixOS:master Apr 18, 2021
@sternenseemann sternenseemann deleted the packagekit-fix-test branch April 18, 2021 17:25
@peterhoeg
Copy link
Member

Good catch @sternenseemann. Not entirely sure what happened here.

@sternenseemann
Copy link
Member Author

sternenseemann commented Apr 20, 2021 via email

@sternenseemann sternenseemann restored the packagekit-fix-test branch July 24, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants