Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbsd.sys: actually build the kernel #119824

Merged
merged 3 commits into from Apr 19, 2021
Merged

netbsd.sys: actually build the kernel #119824

merged 3 commits into from Apr 19, 2021

Conversation

alyssais
Copy link
Member

Motivation for this change

netbsd.sys: actually build the kernel

Before, we were only building the headers, firmware, and bootloader.

CONFIG could be overridden to use another pre-defined kernel, but
there's no way to pass a custom kernel configuration yet.

Tested booting the built kernel in a NetBSD VM.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
netbsd.cksum: init at 8.0
3e9decc 
We need the source directory of this package for config(1), so we
might as well just package it.
@alyssais
netbsd.config: init at 8.0
37ac32a 
Needed to build the NetBSD kernel.
@alyssais
netbsd.sys: actually build the kernel
ddcb48c 
Before, we were only building the headers, firmware, and bootloader.

CONFIG could be overridden to use another pre-defined kernel, but
there's no way to pass a custom kernel configuration yet.

Tested booting the built kernel in a NetBSD VM.
@alyssais alyssais added the 6.topic: bsd Running or building packages on BSD label Apr 19, 2021
@Ericson2314 Ericson2314 merged commit 383afd7 into NixOS:staging Apr 19, 2021
@alyssais alyssais deleted the netbsd-sys branch April 19, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: bsd Running or building packages on BSD 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @Ericson2314