Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: don't build libssp on NetBSD #119872

Merged
merged 1 commit into from Apr 19, 2021
Merged

gcc: don't build libssp on NetBSD #119872

merged 1 commit into from Apr 19, 2021

Conversation

alyssais
Copy link
Member

Motivation for this change

On NetBSD, this is provided by libc, and the GCC version clashes with it.
Disabling it matches the behaviour of pkgsrc on NetBSD.

With this change, I can build pkgsCross.x86_64-netbsd.coreutils on staging.

Fixes: #119839

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

On NetBSD, this is provided by libc, and the GCC version clashes with it.
Disabling it matches the behaviour of pkgsrc on NetBSD.

Fixes: NixOS#119839
@alyssais alyssais added the 6.topic: bsd Running or building packages on BSD label Apr 19, 2021
@github-actions github-actions bot removed the 6.topic: bsd Running or building packages on BSD label Apr 19, 2021
@alyssais alyssais added the 6.topic: bsd Running or building packages on BSD label Apr 19, 2021
@Ericson2314 Ericson2314 merged commit e9c3991 into NixOS:master Apr 19, 2021
@alyssais alyssais deleted the ssp branch April 19, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetBSD headers are overridden by GCC's
2 participants