Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgsync: init at 0.6.6 #119884

Merged
merged 1 commit into from Apr 25, 2021
Merged

pgsync: init at 0.6.6 #119884

merged 1 commit into from Apr 25, 2021

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Apr 19, 2021

Motivation for this change

Need the tool and using gem install fails due to being unable to find openssl/libressl libssl.so.10.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

If it is a tool it should get a top-level entry.

@fabianhjr
Copy link
Member Author

fabianhjr commented Apr 19, 2021

Oh right, should I add an alias like pgsync = rubyPackages.pgsync on top-level/all-packages?

(EDIT: It is already on pkgs/top-level/ruby-packages.nix)

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119884 at dafb7e8d run on x86_64-linux 1

9 packages built successfully:
  • rubyPackages.pgsync (rubyPackages_2_6.pgsync)
  • rubyPackages.tty-cursor (rubyPackages_2_6.tty-cursor)
  • rubyPackages.tty-spinner (rubyPackages_2_6.tty-spinner)
  • rubyPackages_2_7.pgsync
  • rubyPackages_2_7.tty-cursor
  • rubyPackages_2_7.tty-spinner
  • rubyPackages_3_0.pgsync
  • rubyPackages_3_0.tty-cursor
  • rubyPackages_3_0.tty-spinner

Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use bundlerApp, since is more appropriate for tools

@fabianhjr
Copy link
Member Author

Sorry for delay, car crash brought down optical fiber for a couple of blocks including mine and telco was very slow on reconnecting people.

Tested locally on NixOS building package, installing it and running it.

@marsam marsam merged commit 8e7de90 into NixOS:master Apr 25, 2021
@fabianhjr fabianhjr deleted the add-ruby-pgsync branch April 25, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants