Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube3d: 4.4.1 -> 4.4.2 #119938

Merged
merged 1 commit into from Apr 20, 2021
Merged

kube3d: 4.4.1 -> 4.4.2 #119938

merged 1 commit into from Apr 20, 2021

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Apr 20, 2021 •
edited

Motivation for this change

Bump kube3d/k3d to 4.4.2

exclude docgen as we dont use it and it is breaking the build

main module (github.com/rancher/k3d/v4) does not contain package github.com/rancher/k3d/v4/docgen

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
kube3d: 4.4.1 -> 4.4.2
9d70d47 
exclude docgen as we dont use it and it is breaking the build

> main module (github.com/rancher/k3d/v4) does not contain package
github.com/rancher/k3d/v4/docgen
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 119938 run on x86_64-linux 1

1 package built:
  • kube3d

@SuperSandro2000 SuperSandro2000 merged commit fecbe34 into NixOS:master Apr 20, 2021
@06kellyjac 06kellyjac deleted the kube3d branch April 20, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuznero kuznero Awaiting requested review from kuznero

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

@kalbasit kalbasit Awaiting requested review from kalbasit

@ngerstle ngerstle Awaiting requested review from ngerstle

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @SuperSandro2000