Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.scapy: 2.4.4 -> 2.4.5 #119947

Merged
merged 1 commit into from Apr 20, 2021
Merged

python3Packages.scapy: 2.4.4 -> 2.4.5 #119947

merged 1 commit into from Apr 20, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 20, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor April 20, 2021 12:23
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 20, 2021 •
edited

Result of nixpkgs-review pr 119947 at 0677f98 run on aarch64-linux 1

5 packages built successfully:
  • evillimiter
  • home-assistant
  • john
  • python38Packages.scapy
  • python39Packages.scapy

Result of nixpkgs-review pr 119947 at 0677f98 run on x86_64-linux 1

5 packages built successfully:
  • evillimiter
  • home-assistant
  • john
  • python38Packages.scapy
  • python39Packages.scapy

@SuperSandro2000 SuperSandro2000 merged commit bf30ed7 into NixOS:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @r-rmcgibbo @SuperSandro2000