Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc/manual: refine extraLayouts, add warnings an test commands #119952

Merged
merged 1 commit into from Apr 25, 2021

Conversation

attila-lendvai
Copy link
Contributor

Motivation for this change

i have wasted quite some times, and had several questions after i tried to use this feature.

note that i put the closing xml tags are at the end of the line at one place to avoid adding a superfluous space in the output.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
Once the configuration is applied, and you did a logout/login
cycle, the layout should be ready to use: try it by running
<literal>setxkbmap us-greek</literal> and type
<literal>&lt;alt&gt;+a</literal> (it may not get applied in your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this? As far as I know all X and even wayland applications use xkb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know. but without using the gnome layout indicator widget to switch layouts, the new layout doesn't propagate to the gnome x terminal (but it does to e.g. Emacs).

and without the logout/login cycle, it doesn't show up in the list of available layouts. (which makes sense, because otherwise why would it be needed to rebuild the entire X and Gnome and apps locally?)

nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@rnhmjoj rnhmjoj merged commit e035c1b into NixOS:master Apr 25, 2021
@attila-lendvai attila-lendvai deleted the extraLayouts branch April 26, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants