vimPlugins: prefer self over super and, add dependencies for completion-*, gitsigns-nvim, and telescope-* plugins

[malob]

Motivation for this change

It's nice when (Neo)Vim plugins installed via Nix include required plugin dependencies.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 119977 at 25f635e1 run on aarch64-linux 1

2 packages built successfully:

• spacevim
• vimPlugins.telescope-fzy-native-nvim

---

Result of nixpkgs-review pr 119977 at 25f635e1 run on x86_64-linux 1

11 packages built successfully:

• spacevim
• vimPlugins.completion-buffers
• vimPlugins.completion-tabnine
• vimPlugins.completion-treesitter
• vimPlugins.gitsigns-nvim
• vimPlugins.telescope-frecency-nvim
• vimPlugins.telescope-fzf-writer-nvim
• vimPlugins.telescope-fzy-native-nvim
• vimPlugins.telescope-nvim
• vimPlugins.telescope-symbols-nvim
• vimPlugins.telescope-z-nvim

[malob]

Hey @SuperSandro2000, thanks so much as always for the quick review.

Did you ever happen to get a chance to read my comment here?: #119356 (comment)

I suspect I'm just missing something, but if I'm not, wouldn't it be better policy to default to using self when specifying these dependencies rather than super?

[SuperSandro2000]

Did you ever happen to get a chance to read my comment here?: #119356 (comment)

I think I have read it and forgot about it again. I just looked at the file and since most are using super I thought that is the correct way. I think you should update all super to self to prevent that in the future.

I suspect I'm just missing something, but if I'm not, wouldn't it be better policy to default to using self when specifying these dependencies rather than super?

Yeah, it would.

[malob]

Cool. I'll add a commit that makes that change.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 119977 run on x86_64-linux 1

18 packages built:

• spacevim
• vimPlugins.completion-buffers
• vimPlugins.completion-tabnine
• vimPlugins.completion-treesitter
• vimPlugins.ensime-vim
• vimPlugins.gitsigns-nvim
• vimPlugins.ncm2-jedi
• vimPlugins.skim-vim
• vimPlugins.telescope-frecency-nvim
• vimPlugins.telescope-fzf-writer-nvim
• vimPlugins.telescope-fzy-native-nvim
• vimPlugins.telescope-nvim
• vimPlugins.telescope-symbols-nvim
• vimPlugins.telescope-z-nvim
• vimPlugins.vim-addon-nix
• vimPlugins.vim-addon-sql
• vimPlugins.vim-addon-xdebug
• vimPlugins.vimshell-vim