Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.tern: init at 2.5.0 #119995

Merged
merged 2 commits into from Apr 22, 2021
Merged

python3.pkgs.tern: init at 2.5.0 #119995

merged 2 commits into from Apr 22, 2021

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Apr 20, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 20, 2021

Result of nixpkgs-review pr 119995 at 7db5e44f run on aarch64-linux 1

4 packages built successfully:
  • python38Packages.debut
  • python38Packages.tern
  • python39Packages.debut
  • python39Packages.tern
3 suggestions:
  • warning: unused-argument

    Unused argument: fetchFromGitHub.
    Near pkgs/development/python-modules/tern/default.nix:4:3:

      |
    4 | , fetchFromGitHub
      |   ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/tern/default.nix:51:0:

       |
    51 |     description = "A software composition analysis tool and Python library that generates a Software Bill of Materials for container images and Dockerfiles.";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/debut/default.nix:28:0:

       |
    28 |     description = "A python library to parse Debian deb822-style control and copyright files ";
       | ^
    

Result of nixpkgs-review pr 119995 at 7db5e44f run on x86_64-linux 1

4 packages built successfully:
  • python38Packages.debut
  • python38Packages.tern
  • python39Packages.debut
  • python39Packages.tern
3 suggestions:
  • warning: unused-argument

    Unused argument: fetchFromGitHub.
    Near pkgs/development/python-modules/tern/default.nix:4:3:

      |
    4 | , fetchFromGitHub
      |   ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/tern/default.nix:51:0:

       |
    51 |     description = "A software composition analysis tool and Python library that generates a Software Bill of Materials for container images and Dockerfiles.";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/debut/default.nix:28:0:

       |
    28 |     description = "A python library to parse Debian deb822-style control and copyright files ";
       | ^
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants