Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.pyimpfuzzy: init at 0.5 #120004

Merged
merged 1 commit into from Apr 22, 2021
Merged

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Apr 20, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 20, 2021

Result of nixpkgs-review pr 120004 at d0034b32 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.pyimpfuzzy
  • python39Packages.pyimpfuzzy
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/python-modules/pyimpfuzzy/default.nix:27:5:

       |
    27 |     license = licenses.gpl2; # unclear about variant
       |     ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pyimpfuzzy/default.nix:25:0:

       |
    25 |     description = "A Python module which calculates and compares the impfuzzy (import fuzzy hashing)";
       | ^
    

Result of nixpkgs-review pr 120004 at d0034b32 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.pyimpfuzzy
  • python39Packages.pyimpfuzzy
2 suggestions:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pyimpfuzzy/default.nix:25:0:

       |
    25 |     description = "A Python module which calculates and compares the impfuzzy (import fuzzy hashing)";
       | ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/python-modules/pyimpfuzzy/default.nix:27:5:

       |
    27 |     license = licenses.gpl2; # unclear about variant
       |     ^
    

@cole-h cole-h merged commit 313681c into NixOS:master Apr 22, 2021
@cole-h cole-h deleted the pyimpfuzzy branch April 22, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants