python3.pkgs.scancode-toolkit: init at 21.3.31 #120009
Conversation
|
Result of 13 packages failed to build:
23 packages built successfully:
11 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 2 packages failed to build:34 packages built successfully:
16 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 2 packages failed to build:38 packages built successfully:
5 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 2 packages failed to build:38 packages built successfully:
5 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
There was a problem hiding this comment.
sorry about the amount of changes.
collected:
- setuptools-scm goes into nativeBuildInputs
- https should be used for GitHub
- pythonImportsCheck are really nice to have even when checkPhase is run
- pytest should be executed explicitly through pytestCheckHook to avoid silent failures in the future
- if nose is used please executed that directly instead of through setuptools check or pytest
- the new line after
}:is just stylistic
|
I think I got everything, but this PR is a doozy... feel free to re-open any resolved conversations that I missed. EDIT: I don't think having bitarray_0_9 in the top-level is necessary, but I'll happily do it (later). |
| pytestCheckHook | ||
| ]; | ||
|
|
||
| checkPhase = '' |
There was a problem hiding this comment.
I was unable to get tests to work if I set preCheck = "export HOME=$(mktemp -d)"; (the tests would complain about an unwritable home), so this is necessary (unless there's something I overlooked).
There was a problem hiding this comment.
That happens in the pythonImportsCheckPhase, so we can set $HOME in another phase like postInstall and add a comment as to why.
To solve this problem completely, we should introduce prePythonImportsCheck or something. Alternatively, pythonImportsCheck should be executed after pytestCheckPhase.
cc @jonringer @FRidh
There was a problem hiding this comment.
should be able to do as part of preCheck. As I believe pythonImportsCheck is part of the preDist phase
There was a problem hiding this comment.
The real problem is actually addressed later: #120009 (comment)
Importing needs a writable home, and preCheck happens in between pythonImportsCheckPhase and pytestCheckPhase.
There was a problem hiding this comment.
How about we just run preCheck before pythonImportsCheck as well? #120300
cole-h
force-pushed
the
scancode
branch
3 times, most recently
from
f0669d4
to
b0b724a
Compare
|
aarch64 should be fixed by bdbdfe9. I also fixed python39.pkgs in whatever packages it was broken for (by disabling the tests that don't work on python 3.9). |
|
Can we also correct dparse's homepage? |
|
I noticed the same thing -- I'll get to that in the morning. |
|
dparse's homepage has been corrected. |
This fixes builds on aarch64.
|
@ofborg build python3.pkgs.scancode-toolkit |
|
It looks like ofborg is done, but the "Wait for ofborg" check is confused about the state of things. |
@grahamc AFAIK, the darwin check never completed. Also the aarch64 build failed |
|
aarch64 failed because of bitarray's tests failing: #120358. |
That usually takes forever if it completes at all. I think it can be safely ignored. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)