Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polybar: 3.5.2 -> 3.5.5 #120021

Merged
merged 2 commits into from Apr 22, 2021
Merged

polybar: 3.5.2 -> 3.5.5 #120021

merged 2 commits into from Apr 22, 2021

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented Apr 21, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne and afldcr April 21, 2021 03:19
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 21, 2021 •
edited

Result of nixpkgs-review pr 120021 at 158f03a6 run on aarch64-linux 1

2 packages built successfully:
  • polybar
  • polybarFull

Result of nixpkgs-review pr 120021 at 158f03a6 run on x86_64-linux 1

2 packages built successfully:
  • polybar
  • polybarFull
1 suggestion:
  • warning: build-tools-in-build-inputs

    makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/misc/polybar/default.nix:46:5:

       |
46 |     buildInputs = [
   |     ^

Br1ght0ne
Br1ght0ne approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, packages built and working.

@Br1ght0ne Br1ght0ne merged commit 2f9cbff into NixOS:master Apr 22, 2021
@moni-dz moni-dz deleted the update-polybar branch April 22, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@fufexan fufexan fufexan approved these changes

@afldcr afldcr Awaiting requested review from afldcr

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@moni-dz @r-rmcgibbo @SuperSandro2000 @Br1ght0ne @fufexan