New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.sphinx-serve: init at 1.0.1 #120045
Conversation
Result of 2 packages built successfully:
1 suggestion:
Result of 2 packages built successfully:
1 suggestion:
|
c5c9e0e
to
0e40f57
Compare
Fixed test handling based on @r-rmcgibbo feedback. |
0e40f57
to
97c2e3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this package contain a binary which could use a top level entry?
@SuperSandro2000 Indeed it does, but I refrained from exposing it, because sphinx itself also has no top level entry. But I can change that too, to be consistent. |
Then we should probably add one for both to make it easier to find those binaries/scripts. |
@SuperSandro2000 Ok, done. Added each in a separate commit. Thanks again for your support getting this merged. |
Motivation for this change
sphinx-serve was missing from nixpkgs
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)