Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.sphinx-serve: init at 1.0.1 #120045

Merged
merged 3 commits into from Apr 24, 2021

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

sphinx-serve was missing from nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 21, 2021

Result of nixpkgs-review pr 120045 at c5c9e0e7 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.sphinx-serve
  • python39Packages.sphinx-serve
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/sphinx-serve/default.nix:13:0:

       |
    13 |     description = "Spawns a simple HTTP server to preview your sphinx documents";
       | ^
    

Result of nixpkgs-review pr 120045 at c5c9e0e7 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.sphinx-serve
  • python39Packages.sphinx-serve
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/sphinx-serve/default.nix:13:0:

       |
    13 |     description = "Spawns a simple HTTP server to preview your sphinx documents";
       | ^
    

@FlorianFranzen
Copy link
Contributor Author

Fixed test handling based on @r-rmcgibbo feedback.

@FlorianFranzen FlorianFranzen changed the title sphinx-serve: init at 1.0.1 python3Packages.sphinx-serve: init at 1.0.1 Apr 21, 2021
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this package contain a binary which could use a top level entry?

@FlorianFranzen
Copy link
Contributor Author

FlorianFranzen commented Apr 22, 2021

Does this package contain a binary which could use a top level entry?

@SuperSandro2000 Indeed it does, but I refrained from exposing it, because sphinx itself also has no top level entry. But I can change that too, to be consistent.

@SuperSandro2000
Copy link
Member

Indeed it does, but I refrained from exposing it, because sphinx itself also has no top level entry. But I can change that too, to be consistent.

Then we should probably add one for both to make it easier to find those binaries/scripts.

@FlorianFranzen
Copy link
Contributor Author

FlorianFranzen commented Apr 23, 2021

@SuperSandro2000 Ok, done. Added each in a separate commit. Thanks again for your support getting this merged.

@SuperSandro2000 SuperSandro2000 merged commit 4213f6d into NixOS:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants