Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli: 1.19.52 -> 1.19.55 #120066

Closed
wants to merge 3 commits into from
Closed

awscli: 1.19.52 -> 1.19.55 #120066

wants to merge 3 commits into from

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 21, 2021

Result of nixpkgs-review pr 120066 at ace3ea60 run on aarch64-linux 1

8 packages marked as broken and skipped:
  • awsebcli
  • mlflow-server
  • python38Packages.flower
  • python38Packages.geopandas
  • python38Packages.osmnx
  • python39Packages.flower
  • python39Packages.geopandas
  • python39Packages.osmnx
5 packages failed to build:
4 packages skipped due to time constraints:
  • home-assistant
  • python38Packages.tensorboardx
  • python39Packages.tensorboardx
  • tts
115 packages built successfully:
  • aws-adfs (python38Packages.aws-adfs)
  • aws-google-auth
  • aws-mfa
  • aws-sam-cli
  • awscli
  • awslogs
  • barman
  • checkov
  • cloud-custodian
  • credstash (python38Packages.credstash)
  • deja-dup
  • duplicity
  • duply
  • dvc-with-remotes
  • elasticsearch-curator
  • git-remote-codecommit
  • iceshelf
  • lexicon
  • luigi
  • mapproxy
  • nixops
  • python38Packages.aiobotocore
  • python38Packages.aws-sam-translator
  • python38Packages.aws-xray-sdk
  • python38Packages.boto3
  • python38Packages.botocore
  • python38Packages.celery
  • python38Packages.certbot-dns-route53
  • python38Packages.cfn-lint
  • python38Packages.chalice
  • python38Packages.django-anymail
  • python38Packages.django-raster
  • python38Packages.djmail
  • python38Packages.ec2instanceconnectcli
  • python38Packages.flowlogs_reader
  • python38Packages.fs-s3fs
  • python38Packages.gensim
  • python38Packages.gradient
  • python38Packages.hass-nabucasa
  • python38Packages.kombu
  • python38Packages.labelbox
  • python38Packages.mapbox
  • python38Packages.moto
  • python38Packages.pycognito
  • python38Packages.pynamodb
  • python38Packages.rasterio
  • python38Packages.s3fs
  • python38Packages.s3transfer
  • python38Packages.sagemaker
  • python38Packages.sapi-python-client
  • python38Packages.scrapy
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-fake-useragent
  • python38Packages.scrapy-splash
  • python38Packages.serverlessrepo
  • python38Packages.slack-sdk
  • python38Packages.slicedimage
  • python38Packages.smart_open
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy
  • python38Packages.warrant
  • python39Packages.aiobotocore
  • python39Packages.aws-adfs
  • python39Packages.aws-sam-translator
  • python39Packages.aws-xray-sdk
  • python39Packages.boto3
  • python39Packages.botocore
  • python39Packages.celery
  • python39Packages.certbot-dns-route53
  • python39Packages.cfn-lint
  • python39Packages.chalice
  • python39Packages.credstash
  • python39Packages.django-anymail
  • python39Packages.django-raster
  • python39Packages.djmail
  • python39Packages.ec2instanceconnectcli
  • python39Packages.flowlogs_reader
  • python39Packages.fs-s3fs
  • python39Packages.gradient
  • python39Packages.hass-nabucasa
  • python39Packages.kombu
  • python39Packages.labelbox
  • python39Packages.mapbox
  • python39Packages.moto
  • python39Packages.pycognito
  • python39Packages.pynamodb
  • python39Packages.rasterio
  • python39Packages.s3fs
  • python39Packages.s3transfer
  • python39Packages.sagemaker
  • python39Packages.sapi-python-client
  • python39Packages.scrapy
  • python39Packages.scrapy-deltafetch
  • python39Packages.scrapy-fake-useragent
  • python39Packages.scrapy-splash
  • python39Packages.serverlessrepo
  • python39Packages.slack-sdk
  • python39Packages.slicedimage
  • python39Packages.snowflake-connector-python
  • python39Packages.snowflake-sqlalchemy
  • python39Packages.warrant
  • s3bro
  • s4cmd
  • snakemake
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
  • streamlit
4 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/s3transfer/default.nix:47:3:

       |
    47 |   meta = with lib; {
       |   ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/s3transfer/default.nix:50:0:

       |
    50 |     description = "A library for managing Amazon S3 transfers";
       | ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/boto3/default.nix:40:3:

       |
    40 |   meta = {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/botocore/default.nix:43:3:

       |
    43 |   meta = with lib; {
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 120066 at ace3ea60 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • awsebcli
  • mlflow-server
  • python38Packages.flower
  • python38Packages.geopandas
  • python38Packages.osmnx
  • python39Packages.flower
  • python39Packages.geopandas
  • python39Packages.osmnx
1 package failed to build:
1 package skipped due to time constraints:
  • tts
131 packages built successfully:
  • aws-adfs (python38Packages.aws-adfs)
  • aws-google-auth
  • aws-mfa
  • aws-sam-cli
  • awscli
  • awslogs
  • barman
  • bash-my-aws
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • certbot-full
  • checkov
  • cloud-custodian
  • credstash (python38Packages.credstash)
  • deja-dup
  • duplicity
  • duply
  • dvc-with-remotes
  • elasticsearch-curator
  • git-remote-codecommit
  • home-assistant
  • iceshelf
  • lexicon
  • luigi
  • mapproxy
  • nixops
  • python38Packages.aiobotocore
  • python38Packages.aws-sam-translator
  • python38Packages.aws-xray-sdk
  • python38Packages.boto3
  • python38Packages.botocore
  • python38Packages.cartopy
  • python38Packages.celery
  • python38Packages.certbot-dns-route53
  • python38Packages.cfn-lint
  • python38Packages.chalice
  • python38Packages.django-anymail
  • python38Packages.django-raster
  • python38Packages.djmail
  • python38Packages.ec2instanceconnectcli
  • python38Packages.fiona
  • python38Packages.flowlogs_reader
  • python38Packages.fs-s3fs
  • python38Packages.gensim
  • python38Packages.gradient
  • python38Packages.hass-nabucasa
  • python38Packages.kombu
  • python38Packages.labelbox
  • python38Packages.mapbox
  • python38Packages.moto
  • python38Packages.pycognito
  • python38Packages.pynamodb
  • python38Packages.rasterio
  • python38Packages.s3fs
  • python38Packages.s3transfer
  • python38Packages.sagemaker
  • python38Packages.sapi-python-client
  • python38Packages.scrapy
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-fake-useragent
  • python38Packages.scrapy-splash
  • python38Packages.serverlessrepo
  • python38Packages.slack-sdk
  • python38Packages.slicedimage
  • python38Packages.smart_open
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy
  • python38Packages.tensorboardx
  • python38Packages.warrant
  • python39Packages.aiobotocore
  • python39Packages.aws-adfs
  • python39Packages.aws-sam-translator
  • python39Packages.aws-xray-sdk
  • python39Packages.boto3
  • python39Packages.botocore
  • python39Packages.buildbot
  • python39Packages.buildbot-full
  • python39Packages.buildbot-ui
  • python39Packages.cartopy
  • python39Packages.celery
  • python39Packages.certbot-dns-route53
  • python39Packages.cfn-lint
  • python39Packages.chalice
  • python39Packages.credstash
  • python39Packages.django-anymail
  • python39Packages.django-raster
  • python39Packages.djmail
  • python39Packages.ec2instanceconnectcli
  • python39Packages.fiona
  • python39Packages.flowlogs_reader
  • python39Packages.fs-s3fs
  • python39Packages.gradient
  • python39Packages.hass-nabucasa
  • python39Packages.kombu
  • python39Packages.labelbox
  • python39Packages.mapbox
  • python39Packages.moto
  • python39Packages.pycognito
  • python39Packages.pynamodb
  • python39Packages.rasterio
  • python39Packages.s3fs
  • python39Packages.s3transfer
  • python39Packages.sagemaker
  • python39Packages.sapi-python-client
  • python39Packages.scrapy
  • python39Packages.scrapy-deltafetch
  • python39Packages.scrapy-fake-useragent
  • python39Packages.scrapy-splash
  • python39Packages.serverlessrepo
  • python39Packages.slack-sdk
  • python39Packages.slicedimage
  • python39Packages.snowflake-connector-python
  • python39Packages.snowflake-sqlalchemy
  • python39Packages.tensorboardx
  • python39Packages.warrant
  • s3bro
  • s4cmd
  • snakemake
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
  • ssm-session-manager-plugin
  • streamlit
4 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/s3transfer/default.nix:50:0:

       |
    50 |     description = "A library for managing Amazon S3 transfers";
       | ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/boto3/default.nix:40:3:

       |
    40 |   meta = {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/s3transfer/default.nix:47:3:

       |
    47 |   meta = with lib; {
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/botocore/default.nix:43:3:

       |
    43 |   meta = with lib; {
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@SuperSandro2000
Copy link
Member

awscli2 fails with

Executing pipInstallPhase
/build/source/dist /build/source
Processing ./awscli-2.1.35-py2.py3-none-any.whl
Requirement already satisfied: distro<1.6.0,>=1.5.0 in /nix/store/kd59ghxmifq8fj0k80hmbns4f41fzraz-python3.8-distro-1.5.0/lib/python3.8/site-packages (from awscli==2.1.35) (1.5.0)
Requirement already satisfied: ruamel.yaml>=0.15.0 in /nix/store/4p6z5v3s8wgv41b4x60b6q6pgimw44c6-python3.8-ruamel.yaml-0.16.12/lib/python3.8/site-packages (from awscli==2.1.35) (0.16.12)
Requirement already satisfied: prompt-toolkit<3.0.0,>=2.0.0 in /nix/store/cfgb2zj1hpf21hfiad1jjvmykp255qdw-python3.8-prompt_toolkit-2.0.10/lib/python3.8/site-packages (from awscli==2.1.35) (2.0.10)
Requirement already satisfied: colorama>=0.2.5 in /nix/store/hmyyhfcrangfi8y990sfrj5pdlb15lx0-python3.8-colorama-0.4.4/lib/python3.8/site-packages (from awscli==2.1.35) (0.4.4)
Requirement already satisfied: cryptography>=3.3.2 in /nix/store/xvjl332g2ifjrzmwkl83yrxhqhjgz0ls-python3.8-cryptography-3.4.7/lib/python3.8/site-packages (from awscli==2.1.35) (3.4.7)
Requirement already satisfied: docutils>=0.10 in /nix/store/b2aq4x6ynqj0fbsx9lnh0wbc8a5hwsnc-python3.8-docutils-0.16/lib/python3.8/site-packages (from awscli==2.1.35) (0.16)
Requirement already satisfied: botocore==2.0.0dev103 in /nix/store/7hsi9bscdp71p99sbx8s2h8bzfjd8yvg-python3.8-botocore-2.0.0dev103/lib/python3.8/site-packages (from awscli==2.1.35) (2.0.0.dev103)
ERROR: Could not find a version that satisfies the requirement s3transfer<0.4.0,>=0.3.0 (from awscli)
ERROR: No matching distribution found for s3transfer<0.4.0,>=0.3.0


src = fetchPypi {
inherit pname version;
sha256 = "7fdddb4f22275cf1d32129e21f056337fd2a80b6ccef1664528145b72c49e6d2";
sha256 = "sha256-89/XkcrSeZQD48gFGBCnym7h0uYw5dKo+WSdiSvbPbY=";
};

propagatedBuildInputs =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
propagatedBuildInputs =
propagatedBuildInputs = [

Comment on lines +25 to 27
[
botocore
] ++ lib.optional (pythonOlder "3") futures;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[
botocore
] ++ lib.optional (pythonOlder "3") futures;
botocore
] ++ lib.optionals (pythonOlder "3") [ futures ];

@NeQuissimus NeQuissimus changed the title awscli: 1.19.52 -> 1.19.54 awscli: 1.19.52 -> 1.19.55 Apr 22, 2021
@ofborg ofborg bot requested review from bhipple and davegallant April 22, 2021 13:27
@NeQuissimus
Copy link
Member Author

awscli2 needs an update to 2.2.0, I will get around to that sometime this week. 2.2.0 has a new dependency, which we don't have in nixpkgs.

@davegallant davegallant mentioned this pull request Apr 29, 2021
10 tasks
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o

EDIT: why there was an o already, who knows

@@ -13,11 +13,11 @@

buildPythonPackage rec {
pname = "botocore";
version = "1.20.52"; # N.B: if you change this, change boto3 and awscli to a matching version
version = "1.20.57"; # N.B: if you change this, change boto3 and awscli to a matching version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like awscli doesn't like this

builder for '/nix/store/sza90gqk2h0c6s0c6zjbnsf9zfb960c7-awscli-1.19.52.drv' failed with exit code 1; last 10 log lines:
  adding 'awscli-1.19.52.dist-info/top_level.txt'
  adding 'awscli-1.19.52.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/awscli-1.19.52/dist /build/awscli-1.19.52
  Processing ./awscli-1.19.52-py2.py3-none-any.whl
  ERROR: Could not find a version that satisfies the requirement botocore==1.20.52 (from awscli)
  ERROR: No matching distribution found for botocore==1.20.52

@davegallant davegallant mentioned this pull request May 4, 2021
10 tasks
@alexeyre
Copy link
Contributor

Sorry to be annoying, but this is no longer the most up-to-date version of awscli1, 1.19.72 is, could that be the reason I'm getting this error trying to build it?:

ERROR: Could not find a version that satisfies the requirement colorama<0.4.4,>=0.2.5 (from awscli)
ERROR: No matching distribution found for colorama<0.4.4,>=0.2.5

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented May 17, 2021

Sorry to be annoying, but this is no longer the most up-to-date version of awscli1, 1.19.72 is, could that be the reason I'm getting this error trying to build it?:

ERROR: Could not find a version that satisfies the requirement colorama<0.4.4,>=0.2.5 (from awscli)
ERROR: No matching distribution found for colorama<0.4.4,>=0.2.5

We have version 0.4.4. Just substituteInPlace the version range.

@dotlambda
Copy link
Member

Any updates on this?

@dotlambda
Copy link
Member

Actually, these updates have all made it to master already.

@dotlambda dotlambda closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants