Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvme-cli: 1.13 -> 1.14 and remove myself as maintainer #120088

Merged
merged 3 commits into from Apr 22, 2021
Merged

nvme-cli: 1.13 -> 1.14 and remove myself as maintainer #120088

merged 3 commits into from Apr 22, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Apr 21, 2021 •
edited

@tavyc (other maintainer) what's your status? From the Git history your last commit seems to be dcc84d8 from 2017. Does that mean we can entirely remove you as Nixpkgs maintainer (maintainers/maintainer-list.nix) or are you still active?
Edit: Oh, and of course thank you for your past services as maintainer! ❤️

@ofborg ofborg bot requested a review from tavyc April 21, 2021 17:05
@SuperSandro2000 @Mic92
nvme-cli: add mic92 as maintainer
5cbd461 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
@ofborg ofborg bot requested a review from Mic92 April 22, 2021 00:43
@SuperSandro2000 SuperSandro2000 merged commit cfb3bfa into NixOS:master Apr 22, 2021
@primeos primeos mentioned this pull request Apr 22, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tavyc tavyc Awaiting requested review from tavyc

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @Mic92 @SuperSandro2000