Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure-lsp: 2021.02.14-19.46.47 -> 2021.04.13-12.47.33 #120092

Merged
merged 1 commit into from Apr 25, 2021
Merged

clojure-lsp: 2021.02.14-19.46.47 -> 2021.04.13-12.47.33 #120092

merged 1 commit into from Apr 25, 2021

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Apr 21, 2021 •
edited

Motivation for this change

Bump clojure-lsp
The new version don't use lein anymore and is not trivial to build from clojure cli, so I'm using the jar again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ericdallo ericdallo marked this pull request as ready for review April 22, 2021 02:51
@ericdallo
Copy link
Member Author

Result of nixpkgs-review pr 120092 run on x86_64-linux 1

1 package built:
  • clojure-lsp

@ericdallo ericdallo self-assigned this Apr 22, 2021
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 120092 1

1 package built:
  • clojure-lsp

@ericdallo
Copy link
Member Author

Would you mind merge this please @SuperSandro2000 ?

@SuperSandro2000 SuperSandro2000 merged commit cf628a3 into NixOS:master Apr 25, 2021
@ericdallo ericdallo deleted the bump-clojure-lsp branch April 25, 2021 14:59
@ericdallo
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees

@ericdallo ericdallo

Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @thiagokokada @SuperSandro2000