Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-chglog: 0.9.1 -> 0.14.2 #120097

Merged
merged 2 commits into from Apr 24, 2021
Merged

git-chglog: 0.9.1 -> 0.14.2 #120097

merged 2 commits into from Apr 24, 2021

Conversation

hdhog
Copy link
Contributor

@hdhog hdhog commented Apr 21, 2021

Motivation for this change

Update git-chglog version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Apr 21, 2021

on startup ERROR open .chglog/config.yml: no such file or directory, I assume it's normal ? other than that LGTM.
It's good practice to run preBuild/postBuild/preInstall/postInstall hooks when overriding default phases.

@hdhog
Copy link
Contributor Author

hdhog commented Apr 21, 2021

on startup ERROR open .chglog/config.yml: no such file or directory, I assume it's normal ? other than that LGTM.
It's good practice to run preBuild/postBuild/preInstall/postInstall hooks when overriding default phases.

its normal. Before using need execute git-chglog --init this command generate .chglog/config.yml in repo

@hdhog
Copy link
Contributor Author

hdhog commented Apr 21, 2021

maybe move git-chglog --version to postBuild phase for testing success execution

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 21, 2021

Result of nixpkgs-review pr 120097 at 486b049 run on aarch64-linux 1

1 package built successfully:
  • git-chglog
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/go-modules/generic/default.nix:220:5:

        |
    220 |     installPhase = args.installPhase or ''
        |     ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild.

    Near pkgs/development/go-modules/generic/default.nix:145:5:

        |
    145 |     buildPhase = args.buildPhase or ''
        |     ^
    

Result of nixpkgs-review pr 120097 at 486b049 run on x86_64-linux 1

1 package built successfully:
  • git-chglog
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/go-modules/generic/default.nix:220:5:

        |
    220 |     installPhase = args.installPhase or ''
        |     ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild.

    Near pkgs/development/go-modules/generic/default.nix:145:5:

        |
    145 |     buildPhase = args.buildPhase or ''
        |     ^
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants