zellij: init at 0.5.1 #120101
Merged
zellij: init at 0.5.1 #120101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealansh
force-pushed
the
zellij
branch
2 times, most recently
from
7c96f66
to
2cced50
Compare
SuperSandro2000
requested changes
Apr 22, 2021
pkgs/tools/misc/zellij/default.nix
Outdated
Comment on lines
16
to
17
|
|
||
| buildPhase = "cargo make"; |
There was a problem hiding this comment.
Suggested change
| buildPhase = "cargo make"; |
That will most likely not work and break the build in nix. @danieldk any idea how to build using cargo make?
pkgs/top-level/all-packages.nix
Outdated
| @@ -9716,6 +9716,11 @@ in | |||
|
|
|||
| zdelta = callPackage ../tools/compression/zdelta { }; | |||
|
|
|||
| zellij = callPackage ../tools/misc/zellij { | |||
| inherit (darwin.apple_sdk.frameworks) Security SystemConfiguration; | |||
| inherit (darwin) libiconv; | |||
There was a problem hiding this comment.
Suggested change
| inherit (darwin) libiconv; |
|
I think you can write this expression as { lib, fetchFromGitHub, rustPlatform, stdenv, installShellFiles, libiconv }:
rustPlatform.buildRustPackage rec {
pname = "zellij";
version = "0.5.0-beta";
src = fetchFromGitHub {
owner = "zellij-org";
repo = pname;
rev = "v${version}";
sha256 = "0mhxq0pr87lz36wfn3g9yvgx5k6xwf69yvvjvrm3vf1l6hwm9nf6";
};
cargoSha256 = "19465z1yv480hsx153nb7qz4hw1zp9wzqfm90sqsvp06zlpxps8g";
nativeBuildInputs = [ installShellFiles ];
buildInputs = lib.optionals stdenv.isDarwin [ libiconv ];
preCheck = ''
HOME=$TMPDIR
'';
postInstall = ''
installShellCompletion assets/completions/zellij.{bash,fish} --zsh assets/completions/_zellij
'';
meta = with lib; {
description = "A terminal workspace with batteries included";
homepage = "https://zellij.dev/";
license = with licenses; [ mit ];
maintainers = with maintainers; [ therealansh ];
};
} |
SuperSandro2000
approved these changes
Apr 24, 2021
|
@GrahamcOfBorg build zellij |
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)