Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-review: 2.5.0 -> 2.6.0 #120108

Merged
merged 1 commit into from Apr 22, 2021
Merged

nixpkgs-review: 2.5.0 -> 2.6.0 #120108

merged 1 commit into from Apr 22, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 21, 2021

https://github.com/Mic92/nixpkgs-review/releases/tag/2.6.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 21, 2021

Result of nixpkgs-review pr 120108 at ecb137af run on x86_64-linux 1

1 package built successfully:
  • nixpkgs-review
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/tools/package-management/nixpkgs-review/default.nix:26:0:

       |
    26 |     description = "Review pull-requests on https://github.com/NixOS/nixpkgs";
       | ^
    

Result of nixpkgs-review pr 120108 at ecb137af run on aarch64-linux 1

1 package built successfully:
  • nixpkgs-review
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/tools/package-management/nixpkgs-review/default.nix:26:0:

       |
    26 |     description = "Review pull-requests on https://github.com/NixOS/nixpkgs";
       | ^
    

@ofborg ofborg bot requested a review from Mic92 April 21, 2021 22:26
@SuperSandro2000 SuperSandro2000 merged commit ca79e14 into NixOS:master Apr 22, 2021
@zowoq zowoq deleted the nixpkgs-review branch April 22, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants