esbuild: init at v0.11.12 #120121
Closed
esbuild: init at v0.11.12 #120121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Apr 22, 2021
|
|
||
| src = fetchFromGitHub { | ||
| owner = "evanw"; | ||
| repo = "${pname}"; |
There was a problem hiding this comment.
Suggested change
| repo = "${pname}"; | |
| repo = pname; |
| meta = with lib; { | ||
| description = "An extremely fast JavaScript bundler and minifier"; | ||
| homepage = "https://esbuild.github.io/"; | ||
| license = licenses.mit; |
|
|
||
| vendorSha256 = "1n5538yik72x94vzfq31qaqrkpxds5xys1wlibw2gn2am0z5c06q"; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why did you disable tests?
There was a problem hiding this comment.
This is just a leftover because I based this on minify, tests work fine.
fabaff
reviewed
Apr 22, 2021
Co-authored-by: SuperSandro2000 <sandro.jaeckel@posteo.de>
|
Seems that this already got merged in #120089 |
|
Oh, I missed #120089 by a couple hours. We can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add esbuild to nixpkgs.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)