Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeimage: fix for darwin #120124

Merged
merged 1 commit into from Apr 23, 2021
Merged

freeimage: fix for darwin #120124

merged 1 commit into from Apr 23, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 22, 2021
@veprbl veprbl linked an issue Apr 22, 2021 that may be closed by this pull request
Regression: freeimage (unstable-2020-07-04) broken on darwin #120123
Closed
@ofborg ofborg bot requested review from viric and L-as April 22, 2021 00:32
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021 •
edited

Result of nixpkgs-review pr 120124 at d9dadab0 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • colmapWithCuda
  • forge
7 packages failed to build:
13 packages skipped due to time constraints:
  • arrayfire
  • colmap
  • cq-editor
  • emulationstation
  • horizon-eda
  • inkcut
  • opencascade
  • python38Packages.enamlx
  • python38Packages.pythonocc-core
  • python39Packages.enamlx
  • ...
4 packages built successfully:
  • freeimage
  • imv
  • pgf_graphics
  • posterazor

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Result of nixpkgs-review pr 120124 at d9dadab0 run on x86_64-linux 1

1 package failed to build:
19 packages skipped due to time constraints:
  • arrayfire
  • colmap
  • colmapWithCuda
  • cq-editor
  • emulationstation
  • forge
  • horizon-eda
  • inkcut
  • inkscape-extensions.inkcut
  • opencascade
  • ...
14 packages built successfully:
  • cegui
  • freeimage
  • gamecube-tools
  • imv
  • megacmd
  • ogre
  • ogre1_10
  • ogre1_9
  • ogrepaged
  • openxray
  • perceptualdiff
  • pgf_graphics
  • posterazor
  • rucksack

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

L-as
L-as approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine on aarch64-linux (tested imv), but the formatting is a bit odd. I'm not sure if it actually violates the style guide.

@ofborg ofborg bot requested a review from L-as April 22, 2021 13:07
L-as
L-as approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@veprbl veprbl merged commit 638936f into NixOS:master Apr 23, 2021
@veprbl veprbl deleted the pr/freeimage_fix branch April 23, 2021 13:28
@uri-canva uri-canva mentioned this pull request Apr 23, 2021
Merged
10 tasks
@uri-canva uri-canva mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-as L-as L-as approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: freeimage (unstable-2020-07-04) broken on darwin
3 participants
@veprbl @r-rmcgibbo @L-as