Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ace: 6.5.11 -> 7.0.1 #120130

Merged
merged 1 commit into from Apr 22, 2021
Merged

ace: 6.5.11 -> 7.0.1 #120130

merged 1 commit into from Apr 22, 2021

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Apr 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hjones2199
Copy link
Member Author

Result of nixpkgs-review pr 120130 run on x86_64-linux 1

2 packages built:
  • ace
  • yarp

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021

Result of nixpkgs-review pr 120130 at 4fb499f4 run on x86_64-linux 1

2 packages built successfully:
  • ace
  • yarp
1 suggestion:
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/development/libraries/ace/default.nix:21:3:

       |
    21 |   patchPhase = ''substituteInPlace ./MPC/prj_install.pl \
       |   ^
    

Result of nixpkgs-review pr 120130 at 4fb499f4 run on aarch64-linux 1

2 packages built successfully:
  • ace
  • yarp

pkgs/development/libraries/ace/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ace/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ace/default.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants