Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeql: 2.5.0 -> 2.5.2 #120171

Merged
merged 1 commit into from Apr 26, 2021
Merged

codeql: 2.5.0 -> 2.5.2 #120171

merged 1 commit into from Apr 26, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/github/codeql-cli-binaries/releases.

meta.description for codeql is: "Semantic code analysis engine"

meta.homepage for codeql is: "https://semmle.com/codeql"

meta.changelog for codeql is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/3vcvfhai4hl7fa17757w41xx1k2v4dac-codeql-2.5.2/bin/codeql passed the binary check.

  • 0 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 2.5.2 with grep in /nix/store/3vcvfhai4hl7fa17757w41xx1k2v4dac-codeql-2.5.2

  • found 2.5.2 in filename of file in /nix/store/3vcvfhai4hl7fa17757w41xx1k2v4dac-codeql-2.5.2

  • directory tree listing: https://gist.github.com/6474101e895c89708685d20bf4d064ed

  • du listing: https://gist.github.com/6d4e36d8bfa60cab0af31db72d83a1f2


Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
codeql
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/3vcvfhai4hl7fa17757w41xx1k2v4dac-codeql-2.5.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A codeql https://github.com/r-ryantm/nixpkgs/archive/6b883c5d31fa785c15b9d62d3d30bf389f6696fe.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/3vcvfhai4hl7fa17757w41xx1k2v4dac-codeql-2.5.2
ls -la /nix/store/3vcvfhai4hl7fa17757w41xx1k2v4dac-codeql-2.5.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • codeql

Maintainer pings

cc @jollheef for testing.

@fabaff
Copy link
Member

fabaff commented Apr 22, 2021

Result of nixpkgs-review pr 120171 run on x86_64-linux 1

1 package built:
  • codeql

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-120171]$ ./results/codeql/bin/codeql -h
Usage: codeql <command> <argument>...
Create and query CodeQL databases, or work with the QL language.
[...]

Change looks good to me.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120171 at 6b883c5 run on x86_64-linux 1

1 package built successfully:
  • codeql
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/analysis/codeql/default.nix:42:3:

       |
    42 |   installPhase = ''
       |   ^
    

@tomberek tomberek merged commit aefb947 into NixOS:master Apr 26, 2021
@r-ryantm r-ryantm deleted the auto-update/codeql branch April 27, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants