python3Packages.gcsfs: init at 2021.04.0 #120173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make another commit for adding the maintainer |
SuperSandro2000
changed the title
SuperSandro2000
requested changes
Apr 22, 2021
dotlambda
reviewed
Apr 22, 2021
|
Result of 7 packages marked as broken and skipped:
16 packages skipped due to time constraints:
54 packages built successfully:
Result of 18 packages marked as broken and skipped:
10 packages skipped due to time constraints:
47 packages built successfully:
|
|
Result of 5 packages marked as broken and skipped:
11 packages failed to build:
53 packages built:
|
|
@legendofmiracles @SuperSandro2000 I force-pushed a new batch of commits, splitting the maintainer addition into a new commit, and addressing the other comments. |
other changes: - disable test exemption for a bug that a comment claims is no longer valid.
dotlambda
requested changes
Apr 23, 2021
dotlambda
reviewed
Apr 23, 2021
dotlambda
approved these changes
Apr 23, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add gcsfs, a useful tool for working with Google Cloud Storage. gcsfs implements the interfaces described in fsspec, which is in nixpkgs. I needed to bump the versions fsspec to work with the latest release of gcsfs. These packages are developed in unison, so usually need very similar versions.
I sometimes contribute to this project and am in contact with its primary author.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)