Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argo: 3.0.0 -> 3.0.2 #120183

Merged
merged 1 commit into from Apr 22, 2021
Merged

argo: 3.0.0 -> 3.0.2 #120183

merged 1 commit into from Apr 22, 2021

Conversation

lbpdt
Copy link
Contributor

@lbpdt lbpdt commented Apr 22, 2021

Motivation for this change

Also update build info injection, due to paths renaming in 3.0.2:
argoproj/argo-workflows#5059

Supersedes #120145, that bumps the package without updating the build flags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lbpdt lbpdt mentioned this pull request Apr 22, 2021
Closed
@fabaff fabaff changed the title [argo] 3.0.0 -> 3.0.2 argo: 3.0.0 -> 3.0.2 Apr 22, 2021
@ofborg ofborg bot requested review from groodt and kalbasit April 22, 2021 09:48
SuperSandro2000
SuperSandro2000 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash when merging

@lbpdt
Copy link
Contributor Author

lbpdt commented Apr 22, 2021 •
edited

please squash when merging

I already have a single commit so this should be good to merge.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 22, 2021 •
edited

please squash when merging

I already have a single commit so this should be good to merge.

but the message is not correct.

@lbpdt
argo: 3.0.0 -> 3.0.2
b3b984e 
Also update build info injection, due to paths renaming in 3.0.2:
argoproj/argo-workflows#5059
@lbpdt
Copy link
Contributor Author

lbpdt commented Apr 22, 2021

please squash when merging

I already have a single commit so this should be good to merge.

but the message is not correct.

Indeed, I wasn't sure how important this was. Just fixed.

@Ma27 Ma27 merged commit d18e9c5 into NixOS:master Apr 22, 2021
@lbpdt lbpdt deleted the fix/argo-build-info branch April 23, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@groodt groodt Awaiting requested review from groodt

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lbpdt @SuperSandro2000 @Ma27