Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-provider-rancher2: 1.8.3 -> 1.13.0 #120187

Merged

Conversation

lbpdt
Copy link
Contributor

@lbpdt lbpdt commented Apr 22, 2021

Motivation for this change

Also update the repository to be sourced from Rancher's org on GitHub,
as the old repo under terraform-providers/ has been archived:

https://github.com/terraform-providers/terraform-provider-rancher2

The 'About' section mentions how the new location is under rancher/:

https://github.com/rancher/terraform-provider-rancher2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also update the repository to be sourced from Rancher's org on GitHub,
as the old repo under `terraform-providers/` has been archived:

https://github.com/terraform-providers/terraform-provider-rancher2

The 'About' section mentions how the new location is under `rancher/`:

https://github.com/rancher/terraform-provider-rancher2
@lbpdt lbpdt force-pushed the feature/terraform-provider-rancher2 branch from 0dfe56b to 15a78be Compare April 22, 2021 10:21
@lbpdt lbpdt marked this pull request as ready for review April 22, 2021 10:22
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021

Result of nixpkgs-review pr 120187 at 15a78be run on x86_64-linux 1

2 packages built successfully:
  • terraform-full
  • terraform-providers.rancher2

Result of nixpkgs-review pr 120187 at 15a78be run on aarch64-linux 1

2 packages built successfully:
  • terraform-full
  • terraform-providers.rancher2

@lbpdt lbpdt requested a review from timstott April 22, 2021 12:32
Copy link
Contributor

@timstott timstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🎉

nixpkgs-review pr 120187
[nix-shell:~/.cache/nixpkgs-review/pr-120187]$ nix-shell -I nixpkgs=./nixpkgs -p 'terraform.withPlugins (p : with p;[rancher2])'
[nix-shell:~/.cache/nixpkgs-review/pr-120187]$ echo 'provider "rancher2" {}' > providers.tf
[nix-shell:~/.cache/nixpkgs-review/pr-120187]$ terraform init

Initializing the backend...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.rancher2: version = "~> 1.13"

@SuperSandro2000 SuperSandro2000 merged commit 82be9d3 into NixOS:master Apr 24, 2021
@lbpdt lbpdt deleted the feature/terraform-provider-rancher2 branch April 25, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants