Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.whois: 0.9.7 -> 0.9.13 #120215

Merged
merged 1 commit into from Apr 23, 2021
Merged

python3Packages.whois: 0.9.7 -> 0.9.13 #120215

merged 1 commit into from Apr 23, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 22, 2021 •
edited

Motivation for this change

Update to latest upstream release 0.9.13

Change log: https://github.com/DannyCork/python-whois/releases/tag/0.9.13

The source was tagged wrong (mboot-github/python-whois#159).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo

This comment has been minimized.

Sign in to view
SuperSandro2000
SuperSandro2000 reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we update to 0.9.13?

@fabaff
Copy link
Member Author

fabaff commented Apr 22, 2021

Also can we update to 0.9.13?

Yes, we can. Upstream retagged the source. Now the version number is aligned with the tag.

@fabaff fabaff changed the title python3Packages.whois: 0.9.7 -> 0.9.10 python3Packages.whois: 0.9.7 -> 0.9.13 Apr 22, 2021
@fabaff
Copy link
Member Author

fabaff commented Apr 22, 2021

Result of nixpkgs-review pr 120215 run on x86_64-linux 1

3 packages built:
  • dnstwist
  • python38Packages.whois
  • python39Packages.whois

@SuperSandro2000 SuperSandro2000 merged commit e20f279 into NixOS:master Apr 23, 2021
@fabaff fabaff deleted the bump-whois branch April 23, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @r-rmcgibbo @SuperSandro2000