Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antlr3: make C++ includes compatible with C++20 #120234

Merged
merged 1 commit into from Apr 24, 2021

Conversation

cmm
Copy link
Member

@cmm cmm commented Apr 22, 2021

(by stealing the relevant patch from Fedora)

Motivation for this change

upstream does not compile with C++20

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021

Result of nixpkgs-review pr 120234 at 2ea89de2 run on aarch64-linux 1

1 package built successfully:
  • antlr3 (antlr3_5)
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/parsing/antlr/3.5.nix:24:3:

       |
    24 |   installPhase = ''
       |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/parsing/antlr/3.5.nix:18:5:

       |
    18 |     (fetchurl {
       |     ^
    

Result of nixpkgs-review pr 120234 at 2ea89de2 run on x86_64-linux 1

1 package built successfully:
  • antlr3 (antlr3_5)
2 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/parsing/antlr/3.5.nix:18:5:

       |
    18 |     (fetchurl {
       |     ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/parsing/antlr/3.5.nix:24:3:

       |
    24 |   installPhase = ''
       |   ^
    

(by stealing the relevant patch from Fedora)
@SuperSandro2000 SuperSandro2000 merged commit 965d590 into NixOS:master Apr 24, 2021
@cmm cmm deleted the antlr3-c++20 branch April 24, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants