Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbsd.libresolv: fix build #120239

Merged
merged 1 commit into from Apr 22, 2021
Merged

netbsd.libresolv: fix build #120239

merged 1 commit into from Apr 22, 2021

Conversation

alyssais
Copy link
Member

Tested building pkgsCross.x86_64-netbsd.netbsd.libresolv from
x86_64-linux.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
netbsd.libresolv: fix build
ca7f261 
Tested building pkgsCross.x86_64-netbsd.netbsd.libresolv from
x86_64-linux.
@github-actions github-actions bot added the 6.topic: bsd Running or building packages on BSD label Apr 22, 2021
@lukegb
Copy link
Contributor

lukegb commented Apr 22, 2021

@ofborg build pkgsCross.x86_64-netbsd.netbsd.libresolv

@Ericson2314
Copy link
Member

Ericson2314 commented Apr 22, 2021 •
edited

I'm a bit confused on what @matthewbauer was intending as libresolv is built as part of libc, but this seems fine.

@alyssais alyssais merged commit c5ab13f into NixOS:staging Apr 22, 2021
@alyssais alyssais deleted the netbsd-libresolv branch April 23, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: bsd Running or building packages on BSD 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @lukegb @Ericson2314