Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-manager: 3.1.0 -> 3.2.0 #120265

Closed
wants to merge 2 commits into from
Closed

virt-manager: 3.1.0 -> 3.2.0 #120265

wants to merge 2 commits into from

Conversation

Kranzes
Copy link
Member

@Kranzes Kranzes commented Apr 22, 2021

Motivation for this change

Bump to latest version at the time of making this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021

Result of nixpkgs-review pr 120265 at 70d6e01 run on x86_64-linux 1

1 package built successfully:
  • virt-manager
1 suggestion:
  • warning: unused-argument

    Unused argument: glib.
    Near pkgs/applications/virtualization/virt-manager/default.nix:4:30:

      |
    4 | , gsettings-desktop-schemas, glib, libosinfo, gnome3
      |                              ^
    

Result of nixpkgs-review pr 120265 at 70d6e01 run on aarch64-linux 1

1 package built successfully:
  • virt-manager
1 suggestion:
  • warning: unused-argument

    Unused argument: glib.
    Near pkgs/applications/virtualization/virt-manager/default.nix:4:30:

      |
    4 | , gsettings-desktop-schemas, glib, libosinfo, gnome3
      |                              ^
    

@Kranzes Kranzes closed this Apr 22, 2021
@Kranzes Kranzes deleted the bump-virt-manager branch April 22, 2021 23:11
@Kranzes
Copy link
Member Author

Kranzes commented Apr 22, 2021

Deleted because of user-error, sorry.

@Kranzes Kranzes restored the bump-virt-manager branch April 22, 2021 23:14
@Kranzes Kranzes deleted the bump-virt-manager branch April 22, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants