Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim plugins wstrip.vim and vim strip trailing whitespace #120271

Merged
merged 3 commits into from Apr 22, 2021
Merged

Add vim plugins wstrip.vim and vim strip trailing whitespace #120271

merged 3 commits into from Apr 22, 2021

Conversation

dmarcoux
Copy link
Contributor

Motivation for this change

I want to use one of these 2 plugins, so adding them both to be able to try them out.

Things done

I've generated the commits with pkgs/misc/vim-plugins/update.py.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120271 at 4707d4a6 run on x86_64-linux 1

34 packages built successfully:
  • spacevim
  • vimPlugins.chadtree
  • vimPlugins.compe-tabnine
  • vimPlugins.git-worktree-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.lf-vim
  • vimPlugins.lualine-nvim
  • vimPlugins.neogit
  • vimPlugins.nlua-nvim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-bufferline-lua
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-jdtls
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-toggleterm-lua
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.plenary-nvim
  • vimPlugins.sideways-vim
  • vimPlugins.syntastic
  • vimPlugins.telescope-nvim
  • vimPlugins.unicode-vim
  • vimPlugins.vim-choosewin
  • vimPlugins.vim-dadbod
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-gitgutter
  • vimPlugins.vim-gruvbox8
  • vimPlugins.vim-quickrun
  • vimPlugins.vim-signify
  • vimPlugins.vim-startify
  • vimPlugins.vim-strip-trailing-whitespace
  • vimPlugins.vim-which-key
  • vimPlugins.vimspector
  • vimPlugins.wstrip-vim
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

@SuperSandro2000 SuperSandro2000 merged commit b042c22 into NixOS:master Apr 22, 2021
@dmarcoux dmarcoux deleted the add-vim-plugins-wstrip.vim-and-vim-strip-trailing-whitespace branch April 23, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants