Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarGen: don't depend on scandir #120303

Merged
merged 2 commits into from
Apr 23, 2021
Merged

yarGen: don't depend on scandir #120303

merged 2 commits into from
Apr 23, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#119998 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request Apr 23, 2021
Closed
10 tasks
@cole-h cole-h mentioned this pull request Apr 23, 2021
Merged
@dotlambda
Copy link
Member Author

@cole-h Please check whether Neo23x0/yarGen#33 actually works.

@ofborg ofborg bot requested a review from grahamc April 23, 2021 06:18
@dotlambda
Copy link
Member Author

@cole-h I suggest you file that patch upstream first. Apart from that, feel free to push to my branch.

cole-h
cole-h approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(I'll do my patching separately)

jonringer
jonringer approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 120303 run on x86_64-linux 1

1 package built:
  • yarGen

@jonringer jonringer merged commit c21475e into NixOS:master Apr 23, 2021
@dotlambda dotlambda deleted the yarGen-no-scandir branch April 23, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@cole-h cole-h cole-h approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @jonringer @cole-h