Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dask*: various improvements #120318

Merged
merged 3 commits into from May 7, 2021
Merged

python3Packages.dask*: various improvements #120318

merged 3 commits into from May 7, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Apr 23, 2021 •
edited

Also use pytestCheckHook.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from costrouc April 23, 2021 09:31
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 23, 2021 •
edited

Result of nixpkgs-review pr 120318 at 0258f11f run on aarch64-linux 1

1 package marked as broken and skipped:
  • python38Packages.dask-ml
2 packages built successfully:
  • python38Packages.dask-glm
  • python39Packages.dask-glm

Result of nixpkgs-review pr 120318 at 0258f11f run on x86_64-linux 1

3 packages built successfully:
  • python38Packages.dask-glm
  • python38Packages.dask-ml
  • python39Packages.dask-glm

@SuperSandro2000
Copy link
Member

Can you rebase? setuptools-scm got already fixed with #120233

@dotlambda dotlambda mentioned this pull request Apr 24, 2021
Merged
10 tasks
@dotlambda dotlambda changed the title python3Packages.dask-glm: needs setuptools-scm python3Packages.dask-glm: use pytestCheckHook Apr 24, 2021
@dotlambda
Copy link
Member Author

python3Packages.dask fails to build, so I cannot test this.

@FRidh
Copy link
Member

FRidh commented Apr 24, 2021 •
edited

Either wait with this until staging-next is merged or push it to staging-next, to avoid another merge conflict.

@SuperSandro2000
Copy link
Member

/rebase staging-next

@github-actions
Copy link
Contributor

Failed to rebase

@dotlambda dotlambda changed the base branch from master to staging-next April 25, 2021 07:27
@dotlambda dotlambda removed the request for review from matthewbauer April 25, 2021 07:28
@github-actions github-actions bot changed the base branch from staging-next to master April 25, 2021 12:06
@github-actions github-actions bot closed this Apr 25, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@lukegb lukegb reopened this Apr 25, 2021
@FRidh
Copy link
Member

FRidh commented Apr 25, 2021

rebased to master again because staging-next got merged.

@dotlambda
Copy link
Member Author

rebased to master again because staging-next got merged.

You could just have changed the target.

@SuperSandro2000
Copy link
Member

@ofborg build python38Packages.dask

jonringer
jonringer reviewed Apr 27, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really related to your changes, but dask is failing due to attempting to fetch files over network

            if size is False:
>               raise FileNotFoundError(url)
E               FileNotFoundError: https://raw.githubusercontent.com/weierophinney/pastebin/master/public/js-src/dojox/data/tests/stores/patterns.csv

offending tests:

test_bag
test_read_csv

noticed the tests also have @pytest.mark.network might be able to do pytest -m 'not network' to filter them out, would probably be better longterm as well

@dotlambda dotlambda changed the title python3Packages.dask-glm: use pytestCheckHook python3Packages.dask: fix tests Apr 27, 2021
@FRidh
Copy link
Member

FRidh commented Apr 27, 2021

Is this still needed after fc98e85 ?

@dotlambda dotlambda changed the title python3Packages.dask: fix tests python3Packages.dask*: various improvements Apr 27, 2021
@dotlambda
Copy link
Member Author

@nbren12 Can you test this on macOS?

nbren12
nbren12 suggested changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@nbren12 nbren12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. dask failed to build on my mac. See below:

pkgs/development/python-modules/dask/default.nix Show resolved Hide resolved
pkgs/development/python-modules/dask/default.nix Show resolved Hide resolved
@dotlambda dotlambda requested a review from jonringer May 6, 2021 11:48
@dotlambda
Copy link
Member Author

@nbren12 Can you test again on macOS?

nbren12
nbren12 approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@nbren12 nbren12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This built successfully on my mac:

$ nix-build -A python3Packages.dask-ml
/nix/store/sllszglfvy4r325y5r6786j29vw5i93g-python3.8-dask-ml-1.8.0

@dotlambda dotlambda merged commit 1c16013 into NixOS:master May 7, 2021
@dotlambda dotlambda deleted the dask-glm-fix branch May 7, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbren12 nbren12 nbren12 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dotlambda @r-rmcgibbo @SuperSandro2000 @FRidh @nbren12 @jonringer @lukegb