Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.bitarray: 1.8.1 -> 2.0.1 #120323

Merged
merged 1 commit into from Apr 24, 2021
Merged

pythonPackages.bitarray: 1.8.1 -> 2.0.1 #120323

merged 1 commit into from Apr 24, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Apr 23, 2021 •
edited

Motivation for this change

fix tests on aarch64

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from bhipple April 23, 2021 10:23
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120323 at 63a43ed run on x86_64-linux 1

5 packages built successfully:
  • glasgow (python38Packages.glasgow)
  • python38Packages.bitarray
  • python39Packages.bitarray
  • python39Packages.glasgow
  • sacad

@dotlambda dotlambda mentioned this pull request Apr 23, 2021
Closed
10 tasks
@SuperSandro2000
Copy link
Member

@ofborg build python3Packages.bitarray

cole-h
cole-h approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scancode-toolkit builds with --system aarch64-linux now. Thanks :)

@bhipple bhipple merged commit e4e7514 into NixOS:master Apr 24, 2021
@dotlambda dotlambda deleted the bitarray-2.0.1 branch April 24, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@bhipple bhipple Awaiting requested review from bhipple

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @r-rmcgibbo @SuperSandro2000 @cole-h @bhipple