Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lefthook: 0.7.2 -> 0.7.3 #120346

Merged
merged 4 commits into from Apr 24, 2021
Merged

lefthook: 0.7.2 -> 0.7.3 #120346

merged 4 commits into from Apr 24, 2021

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Apr 23, 2021

Motivation for this change

Lefthook (finally) got updated upstream. This fixes the problem that it can't be
used when built with a Go newer than 1.14 (which is marked insecure).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and rencire April 23, 2021 15:02
@bbjubjub2494
Copy link
Member

Result of nixpkgs-review pr 120346 run on x86_64-linux 1

1 package built:
  • lefthook

@dotlambda dotlambda changed the title lefthook: 0.7.2 => 0.7.3 lefthook: 0.7.2 -> 0.7.3 Apr 23, 2021
@SuperSandro2000
Update pkgs/top-level/all-packages.nix
bb809db 
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
SuperSandro2000
SuperSandro2000 reviewed Apr 24, 2021
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 65499c8 into NixOS:master Apr 24, 2021
enderger pushed a commit to enderger/nixpkgs that referenced this pull request Apr 24, 2021
@NobbZ @SuperSandro2000 @enderger
lefthook: 0.7.2 -> 0.7.3 (NixOS#120346)
4612c49 
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@bbjubjub2494 bbjubjub2494 bbjubjub2494 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@rencire rencire Awaiting requested review from rencire

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NobbZ @bbjubjub2494 @SuperSandro2000