Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openra-release: 20190314 - 20210321 #120438

Closed
wants to merge 1 commit into from
Closed

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Apr 23, 2021

Motivation for this change

New release was made.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SFrijters
Copy link
Member

I made an attempt at this before (see #96600) and it seemed like it should be a lot more work.
In this case it looks like the hash wasn't updated, so I would expect this to be just pulled from the cache and actually still be the old version.

@nek0
Copy link
Contributor Author

nek0 commented Apr 24, 2021

I'm sorry. I missed the hash.
There seems to be something missing in the source repo...

@nek0 nek0 closed this Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants