timeline: init at 2.4.0

[davidak]

Motivation for this change

i want to use the package

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 120453 at 6dacc710 run on x86_64-linux 1

3 packages failed to build:

• python38Packages.pysvg-py3
• python39Packages.pysvg-py3
• timeline

2 packages built successfully:

• python38Packages.humblewx
• python39Packages.humblewx

2 suggestions:

• warning: python-include-tests

  Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

  Near pkgs/development/python-modules/humblewx/default.nix:34:0:

     |
  34 |     description = "Library that simplifies creating user interfaces with wxPython";
     | ^
  

• warning: python-inconsistent-interpreters

  Between buildPythonPackage and propagatedBuildInputs, this derivation seems
  to be simultaneously trying to use packages from multiple different Python package sets.
  Mixing package sets like this is not supported.

  Detected Python packages:

  • python3-3.8.8
  • python3-3.9.2

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

---

Result of nixpkgs-review pr 120453 at 6dacc710 run on aarch64-linux 1

3 packages failed to build:

• python38Packages.pysvg-py3
• python39Packages.pysvg-py3
• timeline

2 packages built successfully:

• python38Packages.humblewx
• python39Packages.humblewx

2 suggestions:

• warning: python-include-tests

  Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

  Near pkgs/development/python-modules/humblewx/default.nix:34:0:

     |
  34 |     description = "Library that simplifies creating user interfaces with wxPython";
     | ^
  

• warning: python-inconsistent-interpreters

  Between buildPythonPackage and propagatedBuildInputs, this derivation seems
  to be simultaneously trying to use packages from multiple different Python package sets.
  Mixing package sets like this is not supported.

  Detected Python packages:

  • python3-3.8.8
  • python3-3.9.2

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

---

Result of nixpkgs-review pr 120453 at 88535b69 run on aarch64-linux 1

5 packages built successfully:

• python38Packages.humblewx
• python38Packages.pysvg-py3
• python39Packages.humblewx
• python39Packages.pysvg-py3
• timeline

[davidak]

Result of nixpkgs-review pr 120453 run on x86_64-linux 1

5 packages built:

• python38Packages.humblewx
• python38Packages.pysvg-py3
• python39Packages.humblewx
• python39Packages.pysvg-py3
• timeline

---

Fails to start:

[nix-shell:~/.cache/nixpkgs-review/pr-120453-2]$ timeline
Traceback (most recent call last):
  File "/nix/store/8h7dh80qxvg0bsbp1rxb9k3854ngxdk0-timeline-2.4.0/bin/.timeline-wrapped", line 35, in <module>
    from timelinelib.meta.about import APPLICATION_NAME
  File "/nix/store/8h7dh80qxvg0bsbp1rxb9k3854ngxdk0-timeline-2.4.0/lib/python3.8/site-packages/timelinelib/meta/about.py", line 22, in <module>
    import wx.adv
  File "/nix/store/ii08mxqpcxlywbpirqjk4pnydi9l3b5d-python3.9-wxPython-4.0.7.post2/lib/python3.9/site-packages/wx/__init__.py", line 17, in <module>
    from wx.core import *
  File "/nix/store/ii08mxqpcxlywbpirqjk4pnydi9l3b5d-python3.9-wxPython-4.0.7.post2/lib/python3.9/site-packages/wx/core.py", line 12, in <module>
    from ._core import *
ModuleNotFoundError: No module named 'wx._core'

This only happens in this nix-shell, not when installed with nix-env -f . -iA timeline. Maybe because nixpkgs-review builds all versions.

[davidak]

@rmcgibbo would you be so kind and retest on ARM?

[davidak]

Result of nixpkgs-review pr 120453 run on x86_64-linux 1

1 package built:

• timeline

It works when i test just the one package.

Use this to test the program:

nix run nixpkgs-review -c nixpkgs-review pr 120453 -p timeline

[davidak]

I have rebased and fixed the merge conflict.

Also used it the last days and tested every feature. It works perfectly.

Can we get it merged?

[jonringer]

the nix-shell failure is because the PYTHONPATH is including packages from both interpreters:

  File "/nix/store/8h7dh80qxvg0bsbp1rxb9k3854ngxdk0-timeline-2.4.0/lib/python3.8/site-packages/timelinelib/meta/about.py", line 22, in <module>
    import wx.adv
  File "/nix/store/ii08mxqpcxlywbpirqjk4pnydi9l3b5d-python3.9-wxPython-4.0.7.post2/lib/python3.9/site-packages/wx/__init__.py", line 17, in <module>
    from wx.core import *

This shouldn't be the case in practice, as buildPythonApplication wouldn't export anything on PYTHONPATH.

[jonringer]

otherwise LGTM

[davidak]

@jonringer can you review again?

[jonringer]

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/120453

5 packages built:
python38Packages.humblewx python38Packages.pysvg-py3 python39Packages.humblewx python39Packages.pysvg-py3 timeline