Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just: fix Darwin build #120484

Merged
merged 1 commit into from Apr 24, 2021
Merged

just: fix Darwin build #120484

merged 1 commit into from Apr 24, 2021

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Apr 24, 2021

Motivation for this change

Looks like following the upgrade to just 0.9 it fails to build on macOS due to new dependency libiconv.

   Compiling just v0.9.0 (/private/var/folders/1s/gpt7p1x559sb7qjb_4bhq7zc75yv8y/T/nix-build-just-0.9.0.drv-0/source)
error: linking with `/nix/store/2pb1r2zgw6yiabv4v3d4j66d3vwgdd5q-clang-wrapper-7.1.0/bin/cc` failed: exit code: 1
  |
  = note: "/nix/store/2pb1r2zgw6yiabv4v3d4j66d3vwgdd5q-clang-wrapper-7.1.0/bin/cc" "-m64" "-arch" "x86_64" "-L" "/nix/store/akm781c35gr7mb14g5h0kqlk3cvyzmij-rustc-1.51.0/lib/rustlib/x86_64-apple-darwin/lib" "/private/var/folders/1s/gpt7p1x559sb7qjb_4bhq7zc75yv8y/T/nix-build-just-0.9.0.drv-0/source/target/x86_64-apple-darwin/release/deps/just.just.5y0vo6mm-cgu.1.rcgu.o" "-o" "/private/var/folders/1s/gpt7p1x559sb7qjb_4bhq7zc75yv8y/T/nix-build-just-0.9.0.drv-0/source/target/x86_64-apple-darwin/release/deps/just" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/private/var/folders/1s/gpt7p1x559sb7qjb_4bhq7zc75yv8y/T/nix-build-just-0.9.0.drv-0/source/target/x86_64-apple-darwin/release/deps" "-L" "/private/var/folders/1s/gpt7p1x559sb7qjb_4bhq7zc75yv8y/T/nix-build-just-0.9.0.drv-0/source/target/release/deps" "-L" "/nix/store/akm781c35gr7mb14g5h0kqlk3cvyzmij-rustc-1.51.0/lib/rustlib/x86_64-apple-darwin/lib" "/nix/store/akm781c35gr7mb14g5h0kqlk3cvyzmij-rustc-1.51.0/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-94ac56476cd78265.rlib" "-liconv" "-lSystem" "-lresolv" "-lc" "-lm"
  = note: ld: library not found for -liconv
          clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 24, 2021
@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 120484 run on x86_64-linux 1

@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 120484 run on x86_64-darwin 1

1 package built:
  • just

@Mic92 Mic92 merged commit 5cecebf into NixOS:master Apr 24, 2021
@austinbutler austinbutler deleted the fix-just-darwin branch May 24, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants