Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.joplin: fix Darwin build #120490

Merged
merged 1 commit into from Apr 24, 2021
Merged

nodePackages.joplin: fix Darwin build #120490

merged 1 commit into from Apr 24, 2021

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Apr 24, 2021 •
edited

Motivation for this change

Fixes #98539.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 24, 2021
SuperSandro2000
SuperSandro2000 approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 120490 run on x86_64-darwin 1

1 package built:
  • joplin

@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 120490 run on x86_64-linux 1

@SuperSandro2000 SuperSandro2000 merged commit 747970d into NixOS:master Apr 24, 2021
@austinbutler austinbutler deleted the joplin-fix-darwin branch April 24, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problems install joplin on macos
2 participants
@austinbutler @SuperSandro2000